-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate MobileDialogPrimitive to Tailwind #4127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -371 B (0%) Total Size: 461 kB
ℹ️ View Unchanged
|
mainframev
suggested changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Just one bug, one suggestion and one question ;)
packages/orbit-components/src/primitives/MobileDialogPrimitive/components/DialogContent.tsx
Outdated
Show resolved
Hide resolved
packages/orbit-components/src/primitives/MobileDialogPrimitive/components/DialogContent.tsx
Outdated
Show resolved
Hide resolved
packages/orbit-components/src/primitives/MobileDialogPrimitive/components/DialogContent.tsx
Show resolved
Hide resolved
oreqizer
force-pushed
the
tw/mobile-dialog
branch
from
November 9, 2023 10:35
7564d66
to
2a30fd0
Compare
We can set Tooltip as migrated in the YAML, right? |
oreqizer
force-pushed
the
tw/mobile-dialog
branch
3 times, most recently
from
November 10, 2023 08:34
9a0e6c5
to
82d8ac8
Compare
oreqizer
force-pushed
the
tw/mobile-dialog
branch
from
November 10, 2023 08:37
82d8ac8
to
bed0981
Compare
mainframev
approved these changes
Nov 10, 2023
oreqizer
force-pushed
the
tw/mobile-dialog
branch
from
November 10, 2023 11:33
bed0981
to
1f2513d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEPLT-1793
This Pull Request meets the following criteria:
For tailwind migrations:
Visual regression test suite has been added and run before the migration.This component can't be tested in isolation, it is tested in its usages on other components.This component is not exported, so it's not tracked on this filetailwind-migration-status.yaml
file has been updated with the migrated component(s).Visual regression test suite has been run after the PR approval and no visual changes were identified.Same as aboveMarked as chore because the component is not exported nor documented.
Storybook: https://orbit-mainframev-tw-mobile-dialog.surge.sh